Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an assignment submission for "Nouns, Verbs, and Early Object Structure" which includes an analysis document identifying key entities, roles, attributes, and system components, along with two JavaScript model class skeletons for Conversation and Notification entities.
Changes:
- Added analysis document identifying entities (Conversation, Notification), roles (Moderator, Employee, Authenticated, Guest), attributes (Message ID, Message Content, Attachments, Readers), and system components
- Created Conversation model class with methods for managing messages and participants
- Created Notification model class with properties and methods for handling notifications with rewards, colors, and icons
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| docs/analysis/nouns-and-verbs.md | Analysis document outlining entities, roles, attributes, and system components for the application domain |
| Interlinked/app/lib/js/models/notification.js | Model class skeleton for notifications with properties (message, isRead, timeSent, reward, color, icon) and associated methods |
| Interlinked/app/lib/js/models/conversation.js | Model class skeleton for conversations with message management and participant management methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| - Moderator: set rules, suspend/ban, view reviews | ||
| - Employee: access beta features, create and add content | ||
| - Authenticated: chat, online access, save files on cloud | ||
| - Guest: login/signup, play, read |
There was a problem hiding this comment.
Really lovely that you are thinking of future features like being a Guest account.
Comment on lines
+5
to
+8
| - Conversation | ||
| - verbs: send, delete, edit, read, participants list | ||
| - Notification | ||
| - verbs: send, delete, read, receiveReward |
There was a problem hiding this comment.
I agree that these are Entities. Good job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for Assignment 1: Nouns, Verbs, and Early Object Structure.