Open
Conversation
Change all "Wrap when necessary" to "Wrap all". Also add "never join
already wrapped lines" to give the possibility to manually format
specific lines to never wrap.
With this change, the user is responsible for wrapping when it deems
necessary.
Example:
Before:
/**
* Parameters
*/
class Example {
// line width > 140 will wrap exceeding text
Example(int arg1, int arg2,
int arg3, int arg4,
int arg5, int arg6) {
this();
}
Example() {
}
}
After:
/**
* Parameters
*/
class Example {
// Manually formatted
// If one argument is wrapped, all the other ones are wrapped
Example(
int arg1,
int arg2,
int arg3,
int arg4,
int arg5,
int arg6) {
this();
}
Example() {
}
}
Wrapped and non-wrapped code can be mixed, as long as the same group are
in the same line. Example:
final List<List<String>> data = ImmutableList
.<List<String>>builder()
.add(ImmutableList.<String>builder().add(randomAlphabetic(5)).build())
.build();
Member
Author
|
cc for feedback: @darla-leafnode @clarysabel @cuenyad @vmaletta @abatac @mderamos |
Contributor
|
Hello @nahuelsoldevilla-droptek, |
Member
Author
|
Thanks for the feedback @darla-leafnode! |
nahuel-soldevilla
referenced
this pull request
Mar 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change all "Wrap when necessary" settings to "Wrap all".
With this change, the user is responsible for wrapping when it deems necessary.
Example:
Before:
After:
Wrapped and non-wrapped code can be mixed, as long as the same group are
in the same line. Example:
Right now
Maximum length widthis set to 140 and only the exceeding code will wrap to the next line. With this change, Method chaining is more clear. Example:Before:
After: