Conversation
merge dev
There was a problem hiding this comment.
Pull Request Overview
This PR enables the WAKHAN module in the lr_somatic pipeline, which was previously commented out. WAKHAN is a tool for copy number analysis and visualization from long-read sequencing data.
- Uncomments and fixes the WAKHAN workflow integration with proper input channel preparation
- Updates WAKHAN module to version 0.1.2 with comprehensive output definitions
- Adds configuration parameters and test settings for WAKHAN chromosome selection
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/lr_somatic.nf | Enables WAKHAN workflow and fixes input channel preparation |
| modules/local/wakhan/main.nf | Updates to WAKHAN v0.1.2 with proper output definitions and cleanup |
| nextflow.config | Adds wakhan_chroms parameter for chromosome selection |
| conf/modules.config | Adds WAKHAN process configuration with chromosome filtering and publish settings |
| conf/test.config | Adds test configuration for WAKHAN with chromosome restriction |
| subworkflows/local/prepare_reference_files.nf | Adds empty channel initialization for ASCAT files when not used |
| modules/local/vcfsplit/main.nf | Improves germline VCF processing with proper intermediate file handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| 'https://depot.galaxyproject.org/singularity/wakhan:0.1.1--pyhdfd78af_1': | ||
| 'biocontainers/wakhan:0.1.1--pyhdfd78af_1' }" | ||
| 'https://depot.galaxyproject.org/singularity/wakhan:0.1.2--pyhdfd78af_0 ': | ||
| 'biocontainers/wakhan:0.1.2--pyhdfd78af_0 ' }" |
There was a problem hiding this comment.
There are trailing spaces at the end of the container URL string which should be removed.
| 'biocontainers/wakhan:0.1.2--pyhdfd78af_0 ' }" | |
| 'https://depot.galaxyproject.org/singularity/wakhan:0.1.2--pyhdfd78af_0': | |
| 'biocontainers/wakhan:0.1.2--pyhdfd78af_0' }" |
| 'https://depot.galaxyproject.org/singularity/wakhan:0.1.1--pyhdfd78af_1': | ||
| 'biocontainers/wakhan:0.1.1--pyhdfd78af_1' }" | ||
| 'https://depot.galaxyproject.org/singularity/wakhan:0.1.2--pyhdfd78af_0 ': | ||
| 'biocontainers/wakhan:0.1.2--pyhdfd78af_0 ' }" |
There was a problem hiding this comment.
There are trailing spaces at the end of the container URL string which should be removed.
| 'biocontainers/wakhan:0.1.2--pyhdfd78af_0 ' }" | |
| 'https://depot.galaxyproject.org/singularity/wakhan:0.1.2--pyhdfd78af_0': | |
| 'biocontainers/wakhan:0.1.2--pyhdfd78af_0' }" |
| tabix -p vcf germline_tmp.vcf.gz | ||
|
|
||
|
|
||
| bcftools view germline_tmp.vcf.gz | awk 'BEGIN{FS=OFS="\t"} /^#/ {print} !/^#/ { \$7="PASS"; print }' | \ |
There was a problem hiding this comment.
The awk command uses $7 which escapes the dollar sign unnecessarily. In shell scripts within Nextflow, this should be $7 since the variable substitution is handled by the shell, not Nextflow template expansion.
| bcftools view germline_tmp.vcf.gz | awk 'BEGIN{FS=OFS="\t"} /^#/ {print} !/^#/ { \$7="PASS"; print }' | \ | |
| bcftools view germline_tmp.vcf.gz | awk 'BEGIN{FS=OFS="\t"} /^#/ {print} !/^#/ { $7="PASS"; print }' | \ |
|
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).