Skip to content

fix(Dockerfile): jekyll install #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tevariou merged 9 commits into from
Dec 29, 2021
Merged

fix(Dockerfile): jekyll install #30

tevariou merged 9 commits into from
Dec 29, 2021

Conversation

@tevariou
Copy link
Contributor

@tevariou tevariou commented Dec 8, 2021 •
edited
Loading

Fixes

Fixes https://github.com/arkhn/deployment/issues/532 by @nriss

Description

Change base image in Dockerfile to fix build error

PR opened to fix os type check fail upstream FHIR/sample-ig#54

Definition of Done

  • I followed the Arkhn Code Book (I swear!).
  • I have written tests for the code I added or updated.
  • I have updated the documentation according to my changes.
  • I have updated the deployment configuration if needed.

@tevariou tevariou marked this pull request as draft December 8, 2021 13:59
@tevariou tevariou force-pushed the ci/jekyll_install_fix branch from 2d6b0f2 to 9e91fde Compare December 8, 2021 14:04
simonvadee
simonvadee reviewed Dec 8, 2021
View reviewed changes
@simonvadee simonvadee self-requested a review December 8, 2021 14:05
@tevariou tevariou force-pushed the ci/jekyll_install_fix branch from 9e91fde to d35260c Compare December 8, 2021 14:05
simonvadee
simonvadee reviewed Dec 8, 2021
View reviewed changes
@tevariou tevariou force-pushed the ci/jekyll_install_fix branch 2 times, most recently from 7828dd6 to 3edcc21 Compare December 8, 2021 14:07
@tevariou tevariou requested a review from simonvadee December 8, 2021 14:08
@tevariou tevariou marked this pull request as ready for review December 8, 2021 14:08
@simonvadee
Copy link
Contributor

simonvadee commented Dec 8, 2021

the build is green but it actually failed lol:

#23 [build-image 12/12] RUN ./_genonce.sh -y
#23 0.084 ./_genonce.sh: line 5: curl: command not found
#23 0.084 Checking internet connection...
#23 0.084 Offline
#23 0.084 -tx n/a
#23 0.084 IG Publisher NOT FOUND in input-cache or parent folder. Please run _updatePublisher. Aborting...
#23 DONE 0.1s

@tevariou tevariou force-pushed the ci/jekyll_install_fix branch from 3edcc21 to cdbc113 Compare December 8, 2021 14:11
@tevariou tevariou force-pushed the ci/jekyll_install_fix branch 3 times, most recently from bd5137f to bdfafff Compare December 8, 2021 14:36
@tevariou tevariou force-pushed the ci/jekyll_install_fix branch from 8424bf0 to fab09ca Compare December 8, 2021 14:46
@tevariou tevariou force-pushed the ci/jekyll_install_fix branch 8 times, most recently from 18dd16a to af2e2b8 Compare December 8, 2021 16:40
@tevariou tevariou force-pushed the ci/jekyll_install_fix branch 13 times, most recently from 5860190 to a3857f5 Compare December 9, 2021 00:40
@tevariou tevariou force-pushed the ci/jekyll_install_fix branch from a3857f5 to ee56f07 Compare December 9, 2021 00:51
simonvadee
simonvadee reviewed Dec 13, 2021
View reviewed changes
@tevariou tevariou requested a review from simonvadee December 13, 2021 16:42
@tevariou tevariou force-pushed the ci/jekyll_install_fix branch 4 times, most recently from 3363726 to d8b2c0b Compare December 14, 2021 01:13
simonvadee
simonvadee approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@simonvadee simonvadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, sorry for the delay!

@tevariou tevariou merged commit d9d7232 into main Dec 29, 2021
@tevariou tevariou deleted the ci/jekyll_install_fix branch December 29, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@simonvadee simonvadee simonvadee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tevariou @simonvadee