ENH: code review of recent nifti_image_conflicted_names PR #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmjohnson
force-pushed
the
nifti_image_conflicted_names_followup
branch
from
cefe963 to
a22bf88
Compare
|
@seanm I updated and fixed merge conflicts for this PR. Would you please review and update so that we could incorporate the removal of the "exit()" commands that could cause an application to crash from using this library? |
|
lgtm. What do you want me to update? Not sure I understand that part of your comment... |
|
@seanm At a minimum, the commit message needs to be changed from WIP. |
hjmjohnson
changed the title
|
So you've already mutated my commits here, right? That means what's on my local disk is not the same. If I alter my commit message and push, I'll overwrite what you did I think. I'm not sure how to overcome that because my git-fu is weak... |
In C++ library code, it’s generally considered bad practice to use assert for input validation or error handling. --Terminates the program exit causes dependant applications to terminate - not ideal for libraries meant to be reused safely by others. --Not user-friendly Gives no chance to recover or handle the failure gracefully. --Violates encapsulation Forces application behavior based on internal library assumptions.
hjmjohnson
force-pushed
the
nifti_image_conflicted_names_followup
branch
from
a22bf88 to
fd54dd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.