Skip to content

STYLE: Make NumericTraits::GetLength constexpr whenever possible #5671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hjmjohnson merged 1 commit into from
Dec 4, 2025
+18 −18
Merged

STYLE: Make NumericTraits::GetLength constexpr whenever possible #5671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Modules/Core/Common/include/itkNumericTraits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,14 +198,14 @@ class NumericTraits : public std::numeric_limits<T>
* VariableLengthVector will provide a different implementation
* where a vector of the correct size is built.
*/
static unsigned int
static constexpr unsigned int
GetLength(const T &)
{
return GetLength();
}

/** Return the length of the scalar: 1. Array types can return a different value */
static unsigned int
static constexpr unsigned int
GetLength()
{
return 1;
Expand Down
4 changes: 2 additions & 2 deletions Modules/Core/Common/include/itkNumericTraitsCovariantVectorPixel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,14 +161,14 @@ class NumericTraits<CovariantVector<T, D>>
}

/** Return the length of the vector. */
static unsigned int
static constexpr unsigned int
GetLength(const CovariantVector<T, D> &)
{
return D;
}

/** Return the length of the vector. */
static unsigned int
static constexpr unsigned int
GetLength()
{
return D;
Expand Down
4 changes: 2 additions & 2 deletions Modules/Core/Common/include/itkNumericTraitsDiffusionTensor3DPixel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,14 @@ class NumericTraits<DiffusionTensor3D<T>>
}

/** Return the size of the tensor. Always returns 6. */
static unsigned int
static constexpr unsigned int
GetLength(const DiffusionTensor3D<T> &)
{
return 6;
}

/** Return the size of the tensor. Always returns 6. */
static unsigned int
static constexpr unsigned int
GetLength()
{
return 6;
Expand Down
4 changes: 2 additions & 2 deletions Modules/Core/Common/include/itkNumericTraitsFixedArrayPixel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,14 @@ class NumericTraits<FixedArray<T, D>>
}

/** Return the length of the array. */
static unsigned int
static constexpr unsigned int
GetLength(const FixedArray<T, D> &)
{
return D;
}

/** Return the length of the array. */
static unsigned int
static constexpr unsigned int
GetLength()
{
return D;
Expand Down
4 changes: 2 additions & 2 deletions Modules/Core/Common/include/itkNumericTraitsPointPixel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,14 @@ class NumericTraits<Point<T, D>>
}

/** Return the dimensionality of the point. */
static unsigned int
static constexpr unsigned int
GetLength(const Point<T, D> &)
{
return D;
}

/** Return the dimensionality of the point. */
static unsigned int
static constexpr unsigned int
GetLength()
{
return D;
Expand Down
4 changes: 2 additions & 2 deletions Modules/Core/Common/include/itkNumericTraitsRGBAPixel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,14 +188,14 @@ class NumericTraits<RGBAPixel<T>>
}

/** Return the dimensionality of the pixel. Always returns 4. */
static unsigned int
static constexpr unsigned int
GetLength(const RGBAPixel<T> &)
{
return 4;
}

/** Return the dimensionality of the pixel. Always returns 4. */
static unsigned int
static constexpr unsigned int
GetLength()
{
return 4;
Expand Down
4 changes: 2 additions & 2 deletions Modules/Core/Common/include/itkNumericTraitsRGBPixel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,14 +188,14 @@ class NumericTraits<RGBPixel<T>>
}

/** Return the dimensionality of the pixel. Always returns 3. */
static unsigned int
static constexpr unsigned int
GetLength(const RGBPixel<T> &)
{
return 3;
}

/** Return the dimensionality of the pixel. Always returns 3. */
static unsigned int
static constexpr unsigned int
GetLength()
{
return 3;
Expand Down
4 changes: 2 additions & 2 deletions Modules/Core/Common/include/itkNumericTraitsTensorPixel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,14 @@ class NumericTraits<SymmetricSecondRankTensor<T, D>>
}

/** Return the size of the underlying FixedArray. */
static unsigned int
static constexpr unsigned int
GetLength(const SymmetricSecondRankTensor<T, D> &)
{
return GetLength();
}

/** Return the size of the underlying FixedArray. */
static unsigned int
static constexpr unsigned int
GetLength()
{
return D * (D + 1) / 2;
Expand Down
4 changes: 2 additions & 2 deletions Modules/Core/Common/include/itkNumericTraitsVectorPixel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,14 +203,14 @@ class NumericTraits<Vector<T, D>>
}

/** Return the size of the vector. */
static unsigned int
static constexpr unsigned int
GetLength(const Vector<T, D> &)
{
return D;
}

/** Return the size of the vector. */
static unsigned int
static constexpr unsigned int
GetLength()
{
return D;
Expand Down
Loading