Skip to content

Changed prefix to query_string#25

Open
Mythirion wants to merge 2 commits intoInnerSearch:masterfrom
Mythirion:patch-1
Open

Changed prefix to query_string#25
Mythirion wants to merge 2 commits intoInnerSearch:masterfrom
Mythirion:patch-1

Conversation

@Mythirion
Copy link

This SHOULD allow you to query ES using search terms with spaces in the middle using an analyser, provided you list your field as query? It does require a "text" field. This is untested but I think it should work if my query building knowledge is correct?

This SHOULD allow you to query ES using search terms with spaces in the middle using an analyser, provided you list your field as query? It does require a "text" field. This is untested but I think it should work if my query building knowledge is correct?
@Mythirion
Copy link
Author

In actual fact it may be better to do some sort of if statement to maintain existing compatibility. Just putting this fix out there.

@Mythirion Mythirion closed this Sep 10, 2019
@Mythirion Mythirion reopened this Sep 10, 2019
@ldt
Copy link
Collaborator

ldt commented Sep 12, 2019

Hi @Mythirion,
Thanks for sending this enhancement.
Innersearch was a student project and I don't know if any student is still maintaining it. I was their tutor at the time. I will review your code and validate it today or tomorrow. Ping me if I don't.

Cheers,
Laurent

@Mythirion
Copy link
Author

Ah okay :) makes sense! We managed to get this working, I'll make further changes to my branch to make sure it matches up with our branched version.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants