Skip to content

fix: bigNumber typing#634

Closed
ThomasRalee wants to merge 1 commit intofeat/update-tc-abacus-protosfrom
feat/adapt-to-latest-indexer-changes
Closed

fix: bigNumber typing#634
ThomasRalee wants to merge 1 commit intofeat/update-tc-abacus-protosfrom
feat/adapt-to-latest-indexer-changes

Conversation

@ThomasRalee
Copy link
Copy Markdown
Collaborator

@ThomasRalee ThomasRalee commented Apr 3, 2026

Summary by CodeRabbit

  • Chores
    • Updated build configuration for improved dependency handling.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f8c93a02-1a09-438f-af26-486c838d68d9

📥 Commits

Reviewing files that changed from the base of the PR and between 104c85d and 715ac2c.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • packages/utils/tsdown.config.ts

📝 Walkthrough

Walkthrough

A single line was added to the tsdown build configuration file to mark bignumber.js as an external workspace dependency, ensuring it is not bundled during the build process.

Changes

Cohort / File(s) Summary
Build Configuration
packages/utils/tsdown.config.ts
Added bignumber.js to the external dependency list to treat it as an external workspace dependency during tsdown build.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny tweak in configs bright,
One line added, marked just right,
Big numbers stay external now,
Dependencies bowing low, oh how!
Build optimization takes its flight! 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: bigNumber typing' directly relates to the change made in the pull request, which adds bignumber.js to the external dependencies in the tsdown build configuration to address typing issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/adapt-to-latest-indexer-changes

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedglob@​11.0.3998510050100
Addedglob@​11.1.09910010050100
Addedprotoc@​32.1.0951006895100
Added@​protobuf-ts/​plugin@​2.11.11001008583100
Addedtsup@​8.5.0981009483100
Addedtsup@​8.5.1981009583100
Addedgoogle-protobuf@​4.0.010010010084100
Addedgrpc-web@​1.5.010010010085100
Addedtypescript@​5.9.21001009010090
Addedtypescript@​5.9.31001009010090

View full report

@ThomasRalee ThomasRalee changed the base branch from dev to feat/update-tc-abacus-protos April 7, 2026 16:13
@ThomasRalee ThomasRalee closed this Apr 7, 2026
@ThomasRalee ThomasRalee deleted the feat/adapt-to-latest-indexer-changes branch April 7, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant