Draft
Conversation
ikbuben
reviewed
Feb 18, 2026
|
|
||
| type SessionCancelResponse struct { | ||
| Result string `json:"result"` | ||
| Data Item `json:"data"` |
backend/kdrive/multipart.go
Outdated
| func (u *uploadSession) Abort(ctx context.Context) error { | ||
| opts := rest.Opts{ | ||
| Method: "POST", | ||
| Path: fmt.Sprintf("/3/drive/%s/upload/session/%s/cancel", u.f.opt.DriveID, u.token), |
ikbuben
reviewed
Feb 18, 2026
Comment on lines
-61
to
-66
| }, { | ||
| Name: "account_id", | ||
| Help: `Fill the account ID that is to be considered for this kdrive. | ||
| When showing a folder on kdrive, you can find the account_id here: | ||
| https://ksuite.infomaniak.com/{account_id}/kdrive/app/drive/...`, | ||
| Default: "", |
There was a problem hiding this comment.
note: need to delete this from the doc example as well
| return err | ||
| } | ||
|
|
||
| // purgeCheck removes the root directory, if check is set then it |
|
|
||
| // TODO: check if the following erroneous behavior also happens on kDrive | ||
| // (this workaround comes from the pcloud backend implementation) | ||
| if err != nil { |
ikbuben
reviewed
Feb 19, 2026
Comment on lines
57
to
62
| Name: "root_folder_id", | ||
| Help: "Fill in for rclone to use a non root folder as its starting point.", | ||
| // for default root, see https://developer.infomaniak.com/docs/api/get/3/drive/%7Bdrive_id%7D/files/%7Bfile_id%7D | ||
| Default: "1", | ||
| Default: "5", | ||
| Advanced: true, | ||
| Sensitive: true, |
There was a problem hiding this comment.
thought: I feel like this only makes the backend harder to use. Users shouldn't have to worry about the real root of their drive.
This should be hidden/automated.
There was a problem hiding this comment.
From internal discussion:
1: real root (possible, discouraged)private: commodity for private root, ID resolved at runtime (default)common: commodity for common root, ID resolved at runtime<id>: explicit folder ID
ikbuben
reviewed
Feb 19, 2026
Comment on lines
70
to
72
| Name: "access_token", | ||
| Help: `Access token generated in Infomaniak profile manager.`, | ||
| Default: "", |
There was a problem hiding this comment.
issue: this has to be set to Sensitive: true
Comment on lines
57
to
62
| Name: "root_folder_id", | ||
| Help: "Fill in for rclone to use a non root folder as its starting point.", | ||
| // for default root, see https://developer.infomaniak.com/docs/api/get/3/drive/%7Bdrive_id%7D/files/%7Bfile_id%7D | ||
| Default: "1", | ||
| Default: "5", | ||
| Advanced: true, | ||
| Sensitive: true, |
There was a problem hiding this comment.
From internal discussion:
1: real root (possible, discouraged)private: commodity for private root, ID resolved at runtime (default)common: commodity for common root, ID resolved at runtime<id>: explicit folder ID
| f.dirCache.Put(remote, strconv.Itoa(info.ID)) | ||
|
|
||
| d := fs.NewDir(remote, info.ModTime()).SetID(strconv.Itoa(info.ID)) | ||
| // FIXME more info from dir? |
Comment on lines
1063
to
1067
| // FIXME | ||
| // if apiErr.Code == "not_found" || apiErr.Code == "trashed" { | ||
| // return fs.ErrorObjectNotFound | ||
| // } | ||
| //} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.