chore(unit-tests): Implements unit tests for src/libcommon with the help of OpenCode

[luc-guyot-infomaniak]

No description provided.

[herve-er]

It looks like some of the previous tests are no longer included (see my comments).

Regarding the changes in KeychainManager:

I totally see the benefit of IKeychainStore for testing purposes, but I feel like the keychain handling is becoming a bit overcomplicated.

The current chain (mixing inheritance and members) is:

IKeychainStore → KeychainStore → KeychainManager → KeychainManagerSingleton

KeychainManager mainly acts as a wrapper around KeychainStore methods, adding logging and Sentry reporting. However, logging is already handled everywhere we call KeychainManager(Singleton)::Instance()->…, so this feels somewhat redundant. Its added value is storing _service and _package, but this could probably be handled directly within KeychainStore.

KeychainManagerSingleton simply holds an instance of KeychainManager, effectively acting as a makeshift dependency injection mechanism. I would suggest waiting a proper DI approach instead of relying on these kinds of workarounds.

This is an interesting subject, we can discuss it anytime tomorrow 😄

[sonarqubecloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[luc-guyot-infomaniak]

KeychainManagerSingleton simply holds an instance of KeychainManager, effectively acting as a makeshift dependency injection mechanism. I would suggest waiting a proper DI approach instead of relying on these kinds of workarounds.

This is an interesting subject, we can discuss it anytime tomorrow 😄

The KeyManager was originally a singleton and changing this design has implications which go, in my opinion, much beyond the scope of this PR. With my current proposal, the singleton pattern is preserved while DI is achieved through inheritance by mocking the IKeychainStore.

What the proper DI approach that you envision?