feat: Messages actions use case#2819
Open
solrubado wants to merge 15 commits intoprotected/refactor-mail-actionsfrom
Open
feat: Messages actions use case#2819solrubado wants to merge 15 commits intoprotected/refactor-mail-actionsfrom
solrubado wants to merge 15 commits intoprotected/refactor-mail-actionsfrom
Conversation
FabianDevel
force-pushed
the
network-management
branch
from
8a8e99a to
73350ef
Compare
FabianDevel
force-pushed
the
messages-actions-use-case
branch
from
b80a46a to
3a7ff5e
Compare
solrubado
force-pushed
the
network-management
branch
from
e6d2918 to
cde5dde
Compare
Base automatically changed from
network-management
to
protected/refactor-mail-actions
March 3, 2026 15:22
|
This PR/issue depends on:
|
solrubado
force-pushed
the
messages-actions-use-case
branch
from
3a7ff5e to
3db2f00
Compare
|
FabianDevel
requested changes
Mar 4, 2026
| } else { | ||
| FolderRole.SPAM | ||
| if (displaySnackbar && result != null) { | ||
| showMoveSnackbar(result.movedThreads, result.messages, result.apiResponses, result.destinationFolder) |
Contributor
There was a problem hiding this comment.
Suggested change
| showMoveSnackbar(result.movedThreads, result.messages, result.apiResponses, result.destinationFolder) | |
| with(result) { showMoveSnackbar(movedThreads, messages, apiResponses, destinationFolder) } |
Comment on lines
+549
to
+551
| restrictions.apply { | ||
| blockedSenders.removeIf { it.email == email } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| restrictions.apply { | |
| blockedSenders.removeIf { it.email == email } | |
| } | |
| restrictions.blockedSenders.removeIf { it.email == email } |
| } | ||
|
|
||
| sealed class ApiCallResult { | ||
| data class Success(val messageRes: Int) : ApiCallResult() |
Contributor
There was a problem hiding this comment.
Why did you put a message in success ? I don't think we need it
| else -> listOf(message) | ||
| } | ||
|
|
||
| suspend fun getMessagesFromThreadsToMove(threads: List<Thread>): List<Message> { |
Contributor
There was a problem hiding this comment.
This and the getMessagesFromThreadsToMarkAsUnseen are different from the other getMessagesFromThreadTo
(threads vs thread)
Comment on lines
+503
to
+504
| val result = messagesActionsUseCase.undoAction(undoData, mailbox) | ||
| val message = when (result) { |
Contributor
There was a problem hiding this comment.
Put the result directly in when
|
|
||
| private suspend fun moveOutThreadsLocally(messages: List<Message>, destinationFolder: Folder): List<String> { | ||
| val uidsToMove = mutableListOf<String>().apply { | ||
| messages.flatMapTo(mutableSetOf(), Message::threads).forEach { thread -> |
Contributor
There was a problem hiding this comment.
I see that you now open the realm to get the thread, why do you need to do it now ?
| resources = apiResponses.mapNotNull { it.data?.undoResource }, | ||
| foldersIds = foldersIds, | ||
| destinationFolderId = undoDestinationId, | ||
| threadsMovedCount > 0 || messagesMoved.count() > 1 -> appContext.resources.getQuantityString( |
Contributor
There was a problem hiding this comment.
Add curly bracket and put the getQuantityString on a new line
Comment on lines
+183
to
+187
| val destinationFolderRole = if (folderRole == FolderRole.SPAM) { | ||
| FolderRole.INBOX | ||
| } else { | ||
| FolderRole.SPAM | ||
| } |
Comment on lines
+239
to
+242
| if (apiResponses.atLeastOneFailed()) threadController.updateIsLocallyMovedOutStatus( | ||
| threadsUids = uidsToMove, | ||
| hasBeenMovedOut = false, | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| if (apiResponses.atLeastOneFailed()) threadController.updateIsLocallyMovedOutStatus( | |
| threadsUids = uidsToMove, | |
| hasBeenMovedOut = false, | |
| ) | |
| if (apiResponses.atLeastOneFailed()) { | |
| threadController.updateIsLocallyMovedOutStatus( | |
| threadsUids = uidsToMove, | |
| hasBeenMovedOut = false, | |
| ) | |
| } | |
Comment on lines
+244
to
+245
| val undoDestinationId = messagesToDelete.first().folderId | ||
| val undoFoldersIds = messagesToDelete.getFoldersIds(exception = undoDestinationId) |
Contributor
There was a problem hiding this comment.
Are this necessary if there are no undo action possible ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2814