fix: Prevent forbidden token in web editor after screen restoration#1968
Open
benjaminVadon wants to merge 3 commits intomainfrom
Open
fix: Prevent forbidden token in web editor after screen restoration#1968benjaminVadon wants to merge 3 commits intomainfrom
benjaminVadon wants to merge 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a regression where the OnlyOffice web editor can load with an invalid/forbidden Authorization token after the screen is restored, leading to a 403 | FORBIDDEN in the embedded WebView.
Changes:
- Defers WebView initialization until intent extras are read safely (avoids
!!). - Retrieves the current user/token via
AccountUtils.requestCurrentUser()before building the Authorization header. - Refactors WebView setup into helper methods and adds a dedicated
WebViewClientbuilder.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/main/java/com/infomaniak/drive/ui/OnlyOfficeActivity.kt
Outdated
Show resolved
Hide resolved
…ll init, like if the process was killed before screen restoration # Conflicts: # app/src/main/java/com/infomaniak/drive/ui/OnlyOfficeActivity.kt
benjaminVadon
force-pushed
the
fix-document-preview-token
branch
from
6e14dc5 to
d5f94f9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1953