chore: Update for download of v2 transfers#596
Closed
Conversation
|
This PR/issue depends on: |
|
There was a problem hiding this comment.
Pull request overview
Updates the transfer download/preview flow to support v2 transfers by passing richer transfer context (a TransferUi) into helpers and URL generation, instead of relying solely on transfer.uuid.
Changes:
- Update
downloadManagerId+ related call sites to take aTransferUirather than atransferUuidstring. - Update single-file download URL creation to use
SharedApiUrlCreator.downloadFileUrl(transfer, fileUid).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/transferdetails/TransferManagerExt.kt | Switch preview download ID lookup to use TransferUi when resolving download IDs. |
| app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/transferdetails/TransferDownload.kt | Propagate TransferUi through download-id storage/lookup and use transfer-aware file download URL building. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Superseded by cherry-picked commit in #595 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #595
Depends on Infomaniak/multiplatform-SwissTransfer#254