Add ability to set how truncates work locally vs. one global value. …#2
Open
apatt wants to merge 1 commit into
Open
Add ability to set how truncates work locally vs. one global value. …#2apatt wants to merge 1 commit into
apatt wants to merge 1 commit into
Conversation
…he global set continues to work. also changed the format of a truncated value a bit and actually truncate it to the limit set vs. just showing the memory location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…The global set continues to work. also changed the format of a truncated value a bit and actually truncate it to the limit set vs. just showing the memory location
I know this is not quire complete. I couldn't figure out how to run the unit tests correctly. there was one bug where the original global value is still taking effect (500) even though set_truncation_limit was called.
I think this has something to do with the testing environment because my normal testing showed that this will not happen. If you can provide some guidance on how to property run the unit tests, i would happily clean up the tests and add a few more wit the functionality I added.
This change should be fully backwards compatible other than I actually truncated the data and changed how it was displayed slight to make it cleaner. All functiontionaly will still work exactly as it did before.
my problem is that if i fully install the package, the test fails as described above (my print statements are still there showing that the global var is set correctly all of the way up until it's used) and if I try to run it in a dir on it's own, it can't find the other infi packages, so not sure what the environment should look like. I just ran nosetests.