Update fabric.mod.json and neoforge.mods.toml to match the version supported - #86
Closed
Novampr wants to merge 2 commits into
Closed
Update fabric.mod.json and neoforge.mods.toml to match the version supported#86Novampr wants to merge 2 commits into
Novampr wants to merge 2 commits into
Conversation
Member
|
You've tested that both platforms error on 1.21.5 startup? If only some features are broken we don't want to be so strict. |
Author
|
Yeah, the mod crashes with a missing Minecraft class on start, on 1.21.6 and onwards, no issues were found on 1.21.6 |
Member
Can you provide a stacktrace for each platform? By itself it doesn't crash but I want to be sure it's the command manager itself and not something specific to your command code.
|
Author
|
Heres the logs of the stacktrace, looks to be the command manager: https://mclo.gs/pAYcecR |
Member
|
It looks like that class was added in 1.21.5, so unless something else is broken that can be the minimum Fabric version - for Neo it seems like >=1.21.6 is correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Causes issues if you attempt to launch on lower versions, ideally Fabric and NeoForge should catch this beforehand, but can only do so with the right metadata.