Skip to content

Support Laravel 6 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

DanKeeble
Copy link

No description provided.

@ngrevet
Copy link

ngrevet commented Nov 11, 2019

@DanielKeeble is this working as-is in Laravel 6.x?

@DanKeeble
Copy link
Author

@DanielKeeble is this working as-is in Laravel 6.x?

Yeah appears to be working fine for us.

@ngrevet
Copy link

ngrevet commented Nov 12, 2019

I'm guessing you forked it while you wait for this to be merged/updated?

@DanKeeble
Copy link
Author

I'm guessing you forked it while you wait for this to be merged/updated?

That's correct.

@thiagorb
Copy link

thiagorb commented Dec 12, 2019

A small change is required for the library to work also with lumen 6. In src/Intouch/LaravelNewrelic/LumenNewrelicMiddleware.php, replace:

app()->getRoutes()

with

app()->router->getRoutes()

EDIT
This change was actually introduced in Lumen/Laravel 5.5, so app()->getRoutes() will not work for any version above 5.5, and app()->router->getRoutes() wouldn't work for the versions before 5.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants