Skip to content

[Timeline] Fix #212 by re-applying animation state on scene load - #214

Merged
ManlyMarco merged 1 commit into
IllusionMods:mainfrom
Lusiocc:fix/timeline-resync-state-on-scene-load
Jul 28, 2026
Merged

[Timeline] Fix #212 by re-applying animation state on scene load#214
ManlyMarco merged 1 commit into
IllusionMods:mainfrom
Lusiocc:fix/timeline-resync-state-on-scene-load

Conversation

@Lusiocc

@Lusiocc Lusiocc commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

SceneLoad only re-applied animation state when Autoplay was Yes or No. The default is Ignore, which did neither, and InterpolateBefore/InterpolateAfter early-return while paused. So after a load the cursor and the scene sat on different frames. Added the missing branch: re-apply at the current playback time without touching play state.

Motivation and Context

Fixes #212. Auto Keyframe's "Auto current value" rewrites the keyframe under the cursor from live scene state, so the desync silently destroyed the keyframe at 0:00. The desync itself is reproducible with Auto Keyframe uninstalled.

How Has This Been Tested?

KK, Timeline 1.5.5.1 + Auto Keyframe 1.3.0.0.
Against main, confirming the bug:

  • Cursor/scene desync after load, with Auto Keyframe uninstalled
  • Keyframe at 0:00 overwritten with the card's pose
  • Overwrite follows the cursor, not keyframe 0, parked at 0:05, that keyframe was hit instead
  • Nothing overwritten with the cursor parked between keyframes, despite the desync
  • No overwrite for a card saved at 0:00
  • No overwrite when loaded during playback
  • No overwrite with Autoplay = No

Against the fix:

  • Scene matches the cursor immediately on load, no desync
  • No keyframe modified in any of the repro cases

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Signed-off-by: Lusiocc <252649741+Lusiocc@users.noreply.github.com>
@ManlyMarco
ManlyMarco merged commit e338513 into IllusionMods:main Jul 28, 2026
1 check passed
@HanYuanyi

HanYuanyi commented Jul 30, 2026

Copy link
Copy Markdown

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto Keyframe / Timeline BUG

3 participants