Skip to content

fix(*): replace ApplicationTitle placeholder with the real app title #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgianastasov wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix(*): replace ApplicationTitle placeholder with the real app title #1603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a59ceb1
fix(*): replace ApplicationTitle placeholder with the real app title
georgianastasov Apr 2, 2026
2a143ea
Merge branch 'master' of https://github.com/IgniteUI/igniteui-cli int…
georgianastasov Apr 2, 2026
583b0d3
Update packages/igx-templates/igx-ts/projects/_base/index.ts
georgianastasov Apr 2, 2026
10c24ac
Merge branch 'master' of https://github.com/IgniteUI/igniteui-cli int…
georgianastasov Apr 2, 2026
f732d1a
Merge branch 'ganastasov/fix-app-title-placeholder' of https://github…
georgianastasov Apr 2, 2026
c6b560e
Merge branch 'master' into ganastasov/fix-app-title-placeholder
kdinev Apr 2, 2026
e7f62c8
Merge branch 'master' into ganastasov/fix-app-title-placeholder
kdinev Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/templates/react/igr-ts/projects/_base/files/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title><%=ApplicationTitle%></title>
<title>$(name)</title>
<link rel="stylesheet" href="./styles.css">
</head>
<body>
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/templates/webcomponents/igc-ts/projects/_base/files/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<head>
<meta charset="utf-8">
<base href="/">
<title><%=ApplicationTitle%></title>
<title>$(name)</title>
<link rel="stylesheet" href="./styles.css">
</head>

Expand Down
2 changes: 1 addition & 1 deletion packages/igx-templates/igx-ts/projects/_base/files/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
<title>Ignite UI for Angular</title>
<title><%=name%></title>
<base href="/">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="icon" type="image/x-icon" href="favicon.ico">
Expand Down
2 changes: 1 addition & 1 deletion packages/igx-templates/igx-ts/projects/_base/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ $app-palette: palette($primary, $secondary, $surface);
projectTemplate: this.id,
igxPackage: NPM_ANGULAR,
yamlDefaultBranch: "<%=yaml-default-branch%>", // the placeholder will be evaluated by CodeGen
ApplicationTitle: "<%=ApplicationTitle%>" // the placeholder will be evaluated by CodeGen
ApplicationTitle: name // backward-compat variable; now uses the resolved name value
Copy link
Copy Markdown
Member

@kdinev kdinev Apr 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgianastasov Does codegen also need an update for this?

Copy link
Copy Markdown
Contributor Author

@georgianastasov georgianastasov Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure actually maybe @dkalinovInfra will know better?

Copy link
Copy Markdown
Contributor

@dkalinovInfra dkalinovInfra Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will need to check is codegen using this placeholder, but I think it will be better to not to change the placeholedr to something as generic as 'name'

Copy link
Copy Markdown
Member

@damyanpetev damyanpetev Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkalinovInfra @georgianastasov It's quite possible this placeholder (check the history & see #1237) is absolutely intentionally added like that and intentionally doesn't get replaced just for CodeGen consumption. In which case changing those at all might not be a good idea.

Copy link
Copy Markdown
Member

@damyanpetev damyanpetev Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also possibly related to #1575, but the repo steps in #1603 don't explain what type is created, assuming the base which uses those. Alt solution would be to consider hiding the base from users and clearly marking it for internal use.

Mind you, those placeholders are not how this was supposed to be implemented to begin with IMO.

Copy link
Copy Markdown
Contributor Author

@georgianastasov georgianastasov Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So based on the discussion, it sounds like the <%=ApplicationTitle%> placeholder is intentional for CodeGen consumption and shouldn't be changed. The real fix should be hiding "Base Project" from the user-facing template list (as described in #1575, so users never encounter these pass-through placeholders. Should I close this PR and work on #1575 instead, or is there a different approach you'd prefer?

Copy link
Copy Markdown
Contributor Author

@georgianastasov georgianastasov Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damyanpetev Yep, true.. I really did use the base template here, and I didn’t mention what application type gets created in the repo steps. I’ll fix the description now.

};

switch (theme) {
Expand Down
2 changes: 1 addition & 1 deletion packages/igx-templates/igx-ts/projects/_base_with_home/files/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
<title>Ignite UI for Angular</title>
<title><%=name%></title>
<base href="/">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="icon" type="image/x-icon" href="favicon.ico">
Expand Down
2 changes: 1 addition & 1 deletion packages/igx-templates/igx-ts/projects/base/files/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
<title><%=ApplicationTitle%></title>
<title><%=name%></title>
<base href="/">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="icon" type="image/x-icon" href="favicon.ico">
Expand Down
2 changes: 1 addition & 1 deletion packages/igx-templates/igx-ts/projects/side-nav-auth/files/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
<title>Ignite UI for Angular</title>
<title><%=name%></title>
<base href="/" />
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="icon" type="image/x-icon" href="favicon.ico">
Expand Down
Loading