-
Notifications
You must be signed in to change notification settings - Fork 8
refactor(igx): remove igx-ts-legacy project type #1565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
99cd9c4
refactor(igx): remove igx-ts-legacy project type
damyanpetev d483209
Merge branch 'master' into dpetev/remove-igx-ts-legacy
kdinev 46699ea
Merge branch 'master' into dpetev/remove-igx-ts-legacy
kdinev d882813
refactor(migrations): update legacy type, drop old migs
damyanpetev 8c6e421
refactor(igx-ts): add standalone components to module imports instead
damyanpetev f6e7751
chore: address comments
damyanpetev 91436a2
docs(changelog): update entries, add legacy removal
damyanpetev dbcc7cc
test(migrations): fix schematic call
damyanpetev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { Rule, SchematicContext, Tree } from "@angular-devkit/schematics"; | ||
|
|
||
| export default function(options: any): Rule { | ||
| return (host: Tree, context: SchematicContext) => { | ||
| const igConfig = "./ignite-ui-cli.json"; | ||
|
|
||
| if (host.exists(igConfig)) { | ||
| const content = JSON.parse(host.read(igConfig)!.toString()); | ||
| if (content?.project?.projectType === "igx-ts-legacy") { | ||
| content.project.projectType = "igx-ts"; | ||
| context.logger.info("We've updated your project type to `igx-ts` to continue using Ignite UI CLI. The `igx-ts-legacy` NgModule-based project type is no longer supported. Adding new components might not register correctly."); | ||
| context.logger.info("We recommend using Angular's standalone migration: https://angular.dev/reference/migrations/standalone"); | ||
| host.overwrite(igConfig, JSON.stringify(content, null, 2)); | ||
| } | ||
| } | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,11 @@ | ||
| { | ||
| "$schema": "../node_modules/@angular-devkit/schematics/collection-schema.json", | ||
| "encapsulation": "true", | ||
| "schematics": { | ||
| "migration-01": { | ||
| "version": "2.0.0", | ||
| "description": "Updates Ignite UI for Angular project from 1.3", | ||
| "factory": "./update-2" | ||
| }, | ||
| "migration-02": { | ||
| "version": "3.0.0", | ||
| "description": "Updates Ignite UI for Angular project from 2.1.x", | ||
| "factory": "./update-3" | ||
| }, | ||
| "migration-03": { | ||
| "version": "3.2.0", | ||
| "description": "Updates Ignite UI for Angular project from 3.1.x", | ||
| "factory": "./update-3_2" | ||
| }, | ||
| "migration-04": { | ||
| "version": "4.2.3", | ||
| "description": "Updates Ignite UI for Angular project from 4.2.x", | ||
| "factory": "./update-4_2_3" | ||
| }, | ||
| "migration-05": { | ||
| "version": "5.0.0", | ||
| "description": "Updates Ignite UI for Angular project from CLI 4.4.x to 5.0.0", | ||
| "factory": "./update-5_0_0" | ||
| }, | ||
| "migration-06": { | ||
| "version": "5.0.3", | ||
| "description": "Updates Ignite UI for Angular project from CLI 5.0.x to 5.0.3", | ||
| "factory": "./update-5_0_3" | ||
| }, | ||
| "migration-07": { | ||
| "version": "13.1.0", | ||
| "description": "Updates Ignite UI for Angular Schematics project from 13.0.x to 13.1.x", | ||
| "factory": "./update-13_1_0", | ||
| "schema": "./schema.json" | ||
| } | ||
| "$schema": "../node_modules/@angular-devkit/schematics/collection-schema.json", | ||
| "encapsulation": "true", | ||
| "schematics": { | ||
| "legacy-type": { | ||
| "version": "15.0.0", | ||
| "description": "Updates Ignite UI for Angular Schematics legacy project type to igx-ts", | ||
| "factory": "./legacy-type" | ||
| } | ||
| } | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.