refactor(elements,grid): move childrenResolved event to elements project#17140
Merged
damyanpetev merged 3 commits intomkirova/feat-15235from Mar 31, 2026
Merged
Conversation
…o elements-specific grid components Agent-Logs-Url: https://github.com/IgniteUI/igniteui-angular/sessions/0967549a-3bc1-4fc6-beaf-5c8849c8cd29 Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Agent-Logs-Url: https://github.com/IgniteUI/igniteui-angular/sessions/0967549a-3bc1-4fc6-beaf-5c8849c8cd29 Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
damyanpetev
March 31, 2026 14:25
View session
damyanpetev
reviewed
Mar 31, 2026
projects/igniteui-angular-elements/src/lib/grids/grid.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular-elements/src/lib/grids/hierarchical-grid.component.ts
Outdated
Show resolved
Hide resolved
damyanpetev
reviewed
Mar 31, 2026
projects/igniteui-angular-elements/src/lib/grids/tree-grid.component.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Damyan Petev <damyanpetev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #15226 added a
childrenResolvedevent toIgxGridBaseDirectivein the Angular library, but this event is elements-specific — it's only emitted bycustom-strategy.tsin the elements project. This PR moves it to the elements project source, consistent with PR #15304's goal of relocating all elements-specific members.Changes
childrenResolvedfromgrid-base.directive.tsin the Angular librarychildrenResolvedto the three elements-specific grid components:IgxGridElementsComponentIgxHierarchicalGridElementsComponentIgxTreeGridElementsComponentThe
custom-strategy.tsreferences (componentRef?.instance?.childrenResolved?.emit()) continue to resolve correctly since the event now lives on the elements component instances that the strategy instantiates.