fix(grid): Make sure border does not appear when new theme is loaded runtime.#17032
Open
MayaKirova wants to merge 5 commits into20.1.xfrom
Open
fix(grid): Make sure border does not appear when new theme is loaded runtime.#17032MayaKirova wants to merge 5 commits into20.1.xfrom
MayaKirova wants to merge 5 commits into20.1.xfrom
Conversation
MayaKirova
added
❌ status: awaiting-test
dkamburov
added
✅ status: verified
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a visual regression where merged grid rows can show a bottom border when a new theme stylesheet is loaded at runtime (repro added in the cell merging sample).
Changes:
- Add a runtime theme CSS toggle to the
grid-cellMergingsample to reproduce the issue. - Ensure merged rows don’t render a bottom border by strengthening the merged-row border override in the grid theme styles.
- Remove a repaint-related
recalcUpdateSizes()call from row height resolution logic.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/grid-cellMerging/grid-cellMerging.component.ts | Adds runtime theme stylesheet injection/removal and a signal for button state. |
| src/app/grid-cellMerging/grid-cellMerging.component.html | Adds a toggle button to load/unload the runtime theme CSS. |
| projects/igniteui-angular/src/lib/grids/row.directive.ts | Removes a size-cache recalculation side-effect during row height evaluation. |
| projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss | Forces merged row bottom border to stay removed even under runtime theme overrides. |
| angular.json | Copies grid-cellMerging/theme.css into build assets so it can be loaded at runtime. |
MayaKirova
removed
the
✅ status: verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes IgniteUI/igniteui-angular-samples#3903
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)