fix(grid): Make sure border does not appear when new theme is loaded runtime.#17029
Open
MayaKirova wants to merge 6 commits intomasterfrom
Open
fix(grid): Make sure border does not appear when new theme is loaded runtime.#17029MayaKirova wants to merge 6 commits intomasterfrom
MayaKirova wants to merge 6 commits intomasterfrom
Conversation
MayaKirova
added
❌ status: awaiting-test
MayaKirova
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a grid cell-merging visual regression where a border can reappear after a theme stylesheet is dynamically loaded at runtime (per igniteui-angular-samples issue #3903). It also adds a sample-level runtime theme toggle to reproduce/validate the fix.
Changes:
- Ensures merged-row bottom border stays removed even when a new theme stylesheet is loaded later (SCSS change).
- Removes a repaint-related
recalcUpdateSizes()call from row height calculation logic inIgxRowDirective. - Adds a “Load/Unload Theme CSS” toggle in the grid cell merging sample and updates build assets to ship the sample theme CSS.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/app/grid-cellMerging/grid-cellMerging.component.ts |
Adds runtime theme toggling via dynamic <link rel="stylesheet"> injection and a signal to reflect loaded state. |
src/app/grid-cellMerging/grid-cellMerging.component.html |
Adds a button to load/unload the theme CSS at runtime for verification. |
projects/igniteui-angular/grids/core/src/row.directive.ts |
Removes a conditional call that forced virtual scroll size recalculation when _cdrRequests is set. |
projects/igniteui-angular/core/src/core/styles/components/grid/_grid-theme.scss |
Makes the merged-row border removal more resilient to runtime theme loads by adding !important. |
angular.json |
Copies src/app/grid-cellMerging/theme.css into the built app assets so it can be loaded dynamically. |
dkamburov
added
✅ status: verified
MayaKirova
added
❌ status: awaiting-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes IgniteUI/igniteui-angular-samples#3903
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)