fix(Grid): Add border to rendered height calc.#16908
Open
MayaKirova wants to merge 4 commits into20.1.xfrom
Open
fix(Grid): Add border to rendered height calc.#16908MayaKirova wants to merge 4 commits into20.1.xfrom
MayaKirova wants to merge 4 commits into20.1.xfrom
Conversation
MayaKirova
added
❌ status: awaiting-test
IMinchev64
previously approved these changes
Feb 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an IgxGrid auto-sizing issue where applying a CSS border could cause incorrect rendered height calculations and trigger continuous growth (issue #16640).
Changes:
- Update grid body height calculation to account for host element top/bottom borders.
- Reuse a single computed-style lookup during height calculation.
- Update the auto-size sample styling to include a grid border for reproduction/verification.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
projects/igniteui-angular/src/lib/grids/grid-base.directive.ts |
Adjusts rendered-height calculation to include border thickness when computing available body height. |
src/app/grid-auto-size/grid-auto-size.sample.scss |
Adds a border to igx-grid in the sample to reproduce/validate the sizing behavior. |
dkamburov
added
✅ status: verified
MayaKirova
added
❌ status: awaiting-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16640
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)