Support several required fields during User creation

[francoisfreitag]

Custom User models may have several required attributes, for example a
username and an email. If create is called directly based on
DJANGO_USER_MAIN_ATTRIBUTE, the NOT NULL constraint will be violated,
preventing to save that user. Instead, rely on update_user to call
save when most attributes have been defined on the user.

A nice side effect is that a database query might be saved, because the
INSERT query for new users could contain all attributes when save() is
called from update_user, while a first query (INSERT) was issued to
create the user, then update user would call save(), issuing an UPDATE
query.

[derchrisuk]

Hi,

can you check the PR against the current 0.17.1 version?
I tried to implement just the changes in the backend.py file, but it fails

AttributeError at /saml2/acs/

'function' object has no attribute 'DoesNotExist'

Here are some details:

Django Version: |1.11.15
Exception Type:|AttributeError
Exception Value:|'function' object has no attribute 'DoesNotExist'
Exception Location:|/usr/local/lib/python2.7/site-packages/djangosaml2/backends.py in _get_or_create_saml2_user, line 166
Python Executable:|/usr/local/bin/python
Python Version:|2.7.15

I have to write some more attributes into the django user table, and this would help me a lot.

Thanks,
chris

[francoisfreitag]

I'm surprised by the issue, User is supposed to be a class (subclass of django.contrib.auth.models.AbstractUser), not a function.

What is your SAML_USER_MODEL setting set to?

I may be able to help you further if you can post a failing test case or a minimal django project that fails?

Edit: Link to AbstractUser, not User.

[peppelinux]

Hi, I think that this should be merged soon for the next release, v0.18.2.
Can you refactor your code using get_user_model() instead of User?

This Will let us to use djangosaml2 with a custom user app if you agree.

[francoisfreitag]

Can you precise your request?
User = get_saml_user_model() ensures settings.SAML_USER_MODEL is used when it is defined, otherwise defaults to Django’s auth.get_user_model().

I rebased the PR on master.

[peppelinux]

Can you precise your request?
User = get_saml_user_model() ensures settings.SAML_USER_MODEL is used when it is defined, otherwise defaults to Django’s auth.get_user_model().

I rebased the PR on master.

Yes, you got it, that's it