Metadata EntityID exception #157
Merged
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @peppelinux. |
|
Done |
|
commit rebases, added an error 500 as http status code |
…wing a saml2.mdstore.SourceNotFound Exception. Exception will raise if metadata source is defined as "remote" it's url is not reachable.
|
Changes done, @knaperek if you agree we could merge this and move forward |
|
@knaperek @OskarPersson is it ready to be merged or would it need an additional revision? |
|
Hi guys, is there any news on this? |
|
@knaperek that's happens when a PR is not merged in time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happens that the SP cannot find the EntityID in its Metadata, throwing a saml2.mdstore.SourceNotFound Exception.
More in the deep this Exception will raise if metadata source is defined as "remote" it's url is not reachable.
this PR showes the Error to the user instead of error 500.