Slo absence workaround #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheilatron
reviewed
Jul 6, 2019
sheilatron
reviewed
Jul 6, 2019
sheilatron
reviewed
Jul 6, 2019
|
Thank you for your revisions. Hope to see this merged soon @knaperek, with this commit my pplnx-dev branch and your master branch will be the same and I would use this latter in my project dependencies. |
|
@knaperek @OskarPersson could it be usefull for the next release? |
|
Still missing feedback from a long time, would there be the possibility to handle this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using djangosaml2 with a Saml 2 Saml proxy like SATOSA I found an exception about the absence of SLO in the proxy features.
With this patch I can manage the exception raised by a faulty or absent SLO response.
I needed this to handle different IDP, some with SLO and some Not.
I made a single branch as usual, to make this feature very easy to be read as possible.