Select: Add support for locking clauses #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
lippserd
requested changes
May 19, 2022
| */ | ||
| public function buildFor($lockStrength) | ||
| { | ||
| $sql = []; |
Member
There was a problem hiding this comment.
Why not just return ! empty($lockStrength) ? "FOR $lockStrength" : ""?
| /** | ||
| * Build the locking clause of a query | ||
| * | ||
| * @param ?string $lockStrength |
| * | ||
| * @param string $lockStrength | ||
| * | ||
| * @return self |
| /** | ||
| * Build the locking clause of a query | ||
| * | ||
| * @param ?string $lockStrength |
Member
There was a problem hiding this comment.
I couldn't find the ANSI-SQL definition, but read that this is defined in ANSI-SQL (to an extent, of course). Here is what I found about the implementation in our supported databases:
- MySQL only supports FOR UPDATE
- Oracle and PostgreSQL support is pretty extensive
- DB2 supports FOR UPDATE and FOR READ ONLY
- MSSQL of course does something different and implements this via table hints
Because of the different implementations, I would say locking clause instead of lock strength everywhere. And don't bother with MSSQL for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.