Skip to content

FilterProcessor: Force parentheses around columns in count distinct #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nilmerg wants to merge 1 commit into from
Closed

FilterProcessor: Force parentheses around columns in count distinct #108

nilmerg wants to merge 1 commit into from

Conversation

@nilmerg
Copy link
Member

@nilmerg nilmerg commented May 8, 2023

No description provided.

@nilmerg nilmerg self-assigned this May 8, 2023
@cla-bot cla-bot bot added the cla/signed label May 8, 2023
@nilmerg nilmerg added this to the v0.5.2 milestone May 8, 2023
@nilmerg nilmerg mentioned this pull request May 8, 2023
Closed
@nilmerg
Copy link
Member Author

nilmerg commented May 8, 2023

Not refined and not tested with MySQL yet.

@nilmerg nilmerg removed this from the v0.5.2 milestone May 15, 2023
@nilmerg
Copy link
Member Author

nilmerg commented Jul 6, 2023

MySQL uses a non-standard syntax (COUNT(DISTINCT col1, col2, col3)) to achieve a count distinct over multiple columns. However, it does not support COUNT(DISTINCT (col1, col2, col3)) as PostgreSQL does. Since I didn't find an alternative for either version which is supported by MySQL and PostgreSQL at the same time, generating the queries vendor related seems to be the only way.

@nilmerg
Copy link
Member Author

nilmerg commented Nov 5, 2025

Replaced by #152

@nilmerg nilmerg closed this Nov 5, 2025
@nilmerg nilmerg deleted the fix-postgres-count-distinct branch November 5, 2025 12:50
@nilmerg nilmerg removed their assignment Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla/signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nilmerg