Support ipl\Stdlib\Option for form elements
#157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously attribute setters were also respected when passing options to the constructor. So this is mostly about backwards compatiblity, but it's useful anway, isn't it?
Makes attribute setters effictevely useless!
Member
Author
|
Just noticed, annotating properties is not an option (pun intended) because of inheritance when previously a callback was registered. A subclass may override the setter, which is bypassed when annotating only the property. cc @lippserd |
The attribute setters are kept for now, to ensure backwards compatibility with code relying on them.
nilmerg
force-pushed
the
support-stdlibs-option-for-form-elements
branch
from
e552b58 to
1924bd0
Compare
This was referenced Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Icinga/ipl-stdlib#59