Skip to content

Restore exports #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Restore exports #11

wants to merge 1 commit into from

Conversation

garrison
Copy link
Collaborator

They were dropped (by mistake, I assume) in fb96177.

They were dropped (by mistake, I assume) in fb96177.
@garrison
Copy link
Collaborator Author

I suppose another issue is that the tests are structured such that they didn't notice this.

@codecov-io
Copy link

codecov-io commented Jul 14, 2018

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #11   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          29     29           
=====================================
  Hits           29     29
Impacted Files Coverage Δ
src/Humanize.jl 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17178af...ca73f41. Read the comment docs.

@IainNZ
Copy link
Owner

IainNZ commented Jul 15, 2018

Wasn't a mistake, want to discourage using with my packages and instead encourage explicit imports.

@IainNZ
Copy link
Owner

IainNZ commented Jul 15, 2018

(The tests were changed accordingly)

@garrison
Copy link
Collaborator Author

Hmm, interesting. What is the rationale? (Is this a larger trend or is it currently limited to your packages?)

@IainNZ
Copy link
Owner

IainNZ commented Jul 17, 2018

Rationale is that namespace pollution is bad.
Basically, after two years of Google-ing etc I've become quite into style guides and such, and @mlubin has been looking at doing this for the JuliaOpt-verse. Part of this style guide would be this, so I thought I'd give it a go here.

@IainNZ
Copy link
Owner

IainNZ commented Aug 12, 2018

Closing.

@garrison
Copy link
Collaborator Author

garrison commented May 25, 2024

Fwiw, I never really agreed with this decision. If the user doesn't want namespace pollution, they are always free to write import Humanize instead of using Humanize. IMO removing everything from export in julia makes as much sense as setting __all__ = [] in python for fear that somebody might use from xxx import *. It seems a bit patronizing.

But #21 provides a sensible way forward, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants