feat #170: kotlinx.serilization support #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbourseau
approved these changes
Oct 21, 2025
lilgallon
force-pushed
the
feat/#168-pluggable-serialization-support
branch
from
3210380 to
574f410
Compare
lilgallon
changed the base branch from
feat/#168-pluggable-serialization-support
to
main
The lib had to be changed because 10.00 is different from 10.0 and 10. We needed a lib with more settings
... this could really be a lib, and I think I will extract this code in a lib
lilgallon
force-pushed
the
feat/#170-kotlinx-serialization-support
branch
from
3c5f5c6 to
95f36f9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic
OcpiSerializerinterface maintains compile-time type information throughout the serialization/deserialization process. This design allows the library to utilizekotlinx.serialization's reflection-free approach, ensuring better performance and type safety.The serializer generator was developed to address a key architectural constraint: the domain classes reside in a separate module that must remain independent of any specific marshalling approach (serialization/deserialization). Adding
@Serializableannotations directly to these domain classes would create an unwanted dependency onkotlinx.serialization, violating the module's framework-agnostic design. The generator uses the surrogate pattern to create serialization logic externally, keeping the domain layer clean and allowing different serialization strategies to coexist without modifying the core domain model.The mapping is the same as Jackson, but with better performances. Jackson's mixins behavior is covered with tests, and
kotlinx.serializationimplementation respects themI may create a specific lib for this generator as it can be useful in any
kotlinx.serializationproject, but for now it stays here :)