Draft
Conversation
cjcolvar
reviewed
Mar 4, 2026
cjcolvar
left a comment
cjcolvar
left a comment
There was a problem hiding this comment.
👍 I think it is probably better for this method to return nil instead of raising an error.
I haven't investigated how this impacts consumers of this method though so we'll need to do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In draft status pending investigation of downstream effects of passing along nil result -- which should be fine because we already had a nil guard at the end?
But maybe it's better to get a hard stop to inform us the LDAP connection isn't working?