[IULRDC-144] add new DoiMetadataService, with expanded metadata#220
Open
[IULRDC-144] add new DoiMetadataService, with expanded metadata#220
Conversation
rdlebeau
requested changes
Mar 9, 2026
Contributor
rdlebeau
left a comment
rdlebeau
left a comment
There was a problem hiding this comment.
I have made a few suggestions.
| end | ||
| context "with work.description_abstract" do | ||
| before { work.description_abstract = ['abstract1', 'abstract2'] } | ||
| it "includes Other entries" do |
Contributor
There was a problem hiding this comment.
I think this line should say, it "includes Abstract entries" do
aploshay
force-pushed
the
iulrdc-144_more_doi_metadata
branch
from
269a4d8 to
5b67bdc
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DoiMintingServiceinto newDoiMetadataService