IULRDC-173 DataCORE remove edit work for non-admins on Work view page#218
Open
IULRDC-173 DataCORE remove edit work for non-admins on Work view page#218
Conversation
Contributor
|
The main thing that catches my eye here is that if we're making functional changes to user permissions, I'd expect to see model/controller changes in addition to view changes. We don't need that if we're retaining the user's ability to edit/delete their own submission that's still pending_review, but if we want to completely remove their edit/delete abilities then we should be updating the Ability model. |
Contributor
|
Oh, wait -- I do see the story as written actually does retain the edit/delete ability, just removes those links from the Show page, but retains them on the Dashboard. So this does meet the story as written, I'm just surprised and confused that the story is written that way -- tagged POs in JIRA for confirmation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only admins can see the Edit Work panel on the Work view page now. If the Work is "pending review" a non-admin user can edit or delete it from the dashboard. Non-admin users see a message now where the edit panel used to be unless the Work is Tombstoned.