Conversation
rdlebeau
previously requested changes
Jul 10, 2025
Contributor
rdlebeau
left a comment
rdlebeau
left a comment
There was a problem hiding this comment.
Error on editing a Work in the UI.
Brief summary: Controllers: consolidate #doi_minting_enabled? checks onto service Indexing: revise doi indexing Jobs: reduce logging; return false instead of raising error Presenter, Views, Renderer: consolidate #doi_minting_enabled? checks onto service, general revisions Model DOI Behavior module: revise logic, drop logging and comments Configuration: revise language, drop get access to doi action, add Setting for enabling DOI minting Specs for DOI controller, job, behavior
aploshay
force-pushed
the
ius-1761_doi_generation
branch
from
86f4962 to
5db9173
Compare
Contributor
Author
@rdlebeau try again with the new version of the branch I just force-pushed |
rdlebeau
dismissed
their stale review
An admin user can now edit works with and without files and DOIs successfully.
I approve these changes after viewing the code and testing in the UI.
rdlebeau
approved these changes
Jul 10, 2025
Contributor
rdlebeau
left a comment
rdlebeau
left a comment
There was a problem hiding this comment.
I approve these changes after viewing the code and testing in the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this PR adds new gem, IUBLibTech/datacite-ruby, forked from sul-dlss/datacite-ruby.
Many of the commits here are work around the central focus of getting DOI minting working:
7d92458 move DatasetsController code into modules # not strictly necessary, but seemed a good attack of opportunity amongst the other cleanupmoved into DRAFT controller cleanup #174