[ESSI-61] Bugfix for ESSI-61 structural corruption by node merging#186
Merged
randalldfloyd merged 1 commit intomasterfrom Jan 30, 2019
Merged
[ESSI-61] Bugfix for ESSI-61 structural corruption by node merging#186randalldfloyd merged 1 commit intomasterfrom
randalldfloyd merged 1 commit intomasterfrom
Conversation
…rough id collision
randalldfloyd
approved these changes
Jan 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a structure is converted into an
OrderedList, the existing check for unique ids for each node only checks the currentOrderedList-- and since we are nesting them, id collisions can occur between nodes nested at different levels. This resolves that issue by persisting and sharing thenode_cachebetweenOrderedListinstances.Note that this also required a corresponding change in
ActiveFedora::Orders::OrderedListto allow extending use of existingNodeCache. That change is already present in a new branch on forked active-fedora, but also posted for review as a PR. (We're already pinned to an old release candidate version of active-fedora, so there doesn't seem much harm in forking off of that to make the change we need.)