Adds feature to export positioner pose from a simulation#175
Adds feature to export positioner pose from a simulation#175StephenNneji merged 2 commits intomasterfrom
Conversation
|
Seems to work, if I could be cheeky and request comma separated values in the output file, that would be lovely, but can obviously process the string on our end if needed. I haven't done I functional test of the matrix being output (although I trust it is correct, I just mean testing it does the same thing in mantid) but that might have to wait until we collect the new experimental data at the end of May (when we have the actual physical reference) |
No problem, I will make the output comma separated |
There was a problem hiding this comment.
I tested it and it works as expected. I just wanted to mention one issue. I can't create new environments for sscanss. I get the following error on M1 and M3 macs.
I have some old environments for fitbenchmarking that have Nlopt==2.7.1 installed. I used one of these old conda environments to test the new features of this PR and they work as expected.
Maybe it might be worthwhile to consider updating the numpy dependency to > 2.x.x which will allow installing Nlopt > 2.7.1.
I briefly looked into this. It can be done very easily using ruff. There might be ~13 lines that need to be updated in the codebase. They are the lines that use row_stack.
I will do another PR for upgrading package versions |
@andy-bridger, I had a look at the other exports and tabs are used everywhere, so to keep consistency I will leave the tab separated values as is, but I could revisit in the future maybe by adding a setting to allow the delimiter changes globally. |
This adds the option to download positioner pose (position and orientation) matrices after a simulation. To use the feature:
Does this PR introduce a breaking change (What changes might users need to make in their application due to this PR)?
No
Other information:
