Skip to content

Conversation

SylvainTakerkart
Copy link
Collaborator

This is NOT ready for review! The code is in the state discussed yesterday... I will document it more when I come back from vacation...

But, here is what we decided with @JuliaSprenger yesterday... The current implementation cannot work. What's to be done is:

  1. in the generate_csv_file function, add one column in the csv file, giving the filename (or file directory) where the excel file is

  2. move the read_xls_file so that it is called in the generate_all_metadata function of this specific class (where the instance exists)

@coveralls
Copy link

coveralls commented Oct 21, 2022

Pull Request Test Coverage Report for Build 3641385967

  • 3 of 183 (1.64%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-8.2%) to 68.25%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bep032tools/generator/BEP032NWDataConverter.py 0 180 0.0%
Totals Coverage Status
Change from base Build 3641356290: -8.2%
Covered Lines: 1135
Relevant Lines: 1663

💛 - Coveralls

@JuliaSprenger
Copy link
Collaborator

@SylvainTakerkart I fixed some error in the CI in master. You might need to merge the new master version here so the tests are passing also in this branch.

@JuliaSprenger
Copy link
Collaborator

Hi @SylvainTakerkart I fixed a the np.isnan bug in master and merged master into your feature branch here. Can you pull again to work on the latest version also locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants