Skip to content

add dark mode arrow #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kej-r03 wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

add dark mode arrow #268

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04516a6
add dark mode arrow
Kej-r03 Feb 18, 2023
faae1d0
fix loadIcons
Kej-r03 Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions library/javascript/components/slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,16 +123,25 @@ document.addEventListener('DOMContentLoaded', function (e) {

const leftArrowElement = document.createElement('img')
leftArrowElement.className = 'arrow'
leftArrowElement.setAttribute('src', leftArrow)
leftArrowElement.setAttribute('data-icon', 'carouselleft')
leftArrowElement.classList.add('ui')
leftArrowElement.classList.add('icon')
leftArrowElement.classList.add('prev')
leftArrowElement.classList.add('icon_image')
Copy link
Contributor

@ParitoshKabra ParitoshKabra Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the class icon_image already there? Was it that since it was not include the arrows used yo work bad?

Copy link
Contributor Author

@Kej-r03 Kej-r03 Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the class names that I have added are present in the other dark mode arrows too. But the actual classes that are responsible for the dark mode feature are "icon" and "data-icon"

leftArrowContainer.appendChild(leftArrowElement)

const rightArrowContainer = document.createElement('div')
rightArrowContainer.className = 'right-arrow-container'

const rightArrowElement = document.createElement('img')
rightArrowElement.className = 'arrow'
rightArrowElement.setAttribute('src', rightArrow)
rightArrowElement.setAttribute('data-icon', 'carouselright')
rightArrowElement.classList.add('ui')
rightArrowElement.classList.add('icon')
rightArrowElement.classList.add('next')
rightArrowElement.classList.add('icon_image')
rightArrowContainer.appendChild(rightArrowElement)
loadIcons()

sliders[i].appendChild(leftArrowContainer)
sliders[i].appendChild(container)
Expand Down