Add PEP 621-compliant pyproject.toml
, keep setup.py
and requirements.txt
untouched as legacy
#428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170 and other issues
Root problem:
setup.py
requires another package's build environment to havetorch
installed - or it "helps" by trying to installtorch
itself, which is not possible when usinguv
,poetry
or other non-pip build systemsMinimal reproducible setup:
Step into a temp directory, create an isolated environment with
uv
(also works withpoetry
):Create a new project:
Add grounding dino as git-dependency:
Try to resolve depednencies into a
requirements-lock.txt
file, observe error:Now, try to change dependency to current fork branch to test it:
Try again - success, dependencies locked! 🎉 Click below to see locked file.