build: switch from required to imports in custom lib modules #1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiri
force-pushed
the
s870-consistent-imports
branch
2 times, most recently
from
e177024 to
6918612
Compare
eiri
force-pushed
the
s870-consistent-imports
branch
from
dcd2221 to
206ab65
Compare
mojito317
reviewed
Aug 13, 2024
eiri
force-pushed
the
s870-consistent-imports
branch
from
206ab65 to
753c58e
Compare
mojito317
reviewed
Sep 18, 2024
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
There was a problem hiding this comment.
Changing extension of this file to .mjs will need changes in README rendering as well.
This comment is also relevant to the other files in this directory.
There was a problem hiding this comment.
Yes, but that's in templates and since README's already resolved and examples embedded I expect this PR doesn't break it, just needs a followup in templates in upstream.
mojito317
approved these changes
Sep 18, 2024
|
@mojito317 it turned out jest was ignoring mjs tests and once I configured it not to it became really hard to make mix of cjs and esm import styles to work together in tests. So this PR superseded by #1629 that uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This is a build refactoring work that makes sure we are using esm style imports in all of our custom modules.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
We have a mix of
importandrequiredstatements.What is the new behavior?
We still have
requiredin generated modules, but our custom modules are now have consistent imports.Does this PR introduce a breaking change?
Other information