add disabled field to services and service links #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnywu
reviewed
Jun 27, 2025
jon8787
reviewed
Jun 27, 2025
| @@ -73,6 +86,7 @@ public String toString() { | |||
| ", name='" + name + '\'' + | |||
| ", roles=" + roles + | |||
| ", linkIdRegex=" + linkIdRegex + | |||
| ", disabled=" + disabled + | |||
There was a problem hiding this comment.
didn't we decide to use lombok at some point?
| ServiceLink l3 = addServiceLink(content, "ghi789", 1, 123, "Test Service 1", Set.of(Role.MAPPER, Role.SHARER)); | ||
| ServiceLink l4 = addServiceLink(content, "jkl1011", 3, 124, "test2", null); | ||
| ServiceLink l1 = addServiceLink(content, "abc123", 1, 123, "Test Service 1", Set.of(), false); | ||
| ServiceLink l2 = addServiceLink(content, "abc123", 2, 123, "test1", Set.of(Role.MAPPER), true); |
There was a problem hiding this comment.
we are introducing a mix of enabled/disabled in the test but what tests or assertions are we doing with these?
There was a problem hiding this comment.
containsAll will use .equals()
There was a problem hiding this comment.
Just curious, will there be tests be that assert that disabling a service link or service actually does disable it? Where would these go?
There was a problem hiding this comment.
Operator, as this is where we will check if it's disabled
sunnywu
reviewed
Jun 30, 2025
sunnywu
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.