-
-
Notifications
You must be signed in to change notification settings - Fork 7
Allow Decypharr to be used #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Making this value true by default will cause the user to be unable to login, and no value is set for login credentials during onboarding.
|
GitKraken automatically performed 2 actions
Create your own automations at gitkraken.dev/automations |
WalkthroughChanged the default value of final_config["use_auth"] from True to False in the extended Decypharr settings construction. No other logic, control flow, or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
utils/decypharr_settings.py(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
utils/decypharr_settings.py (1)
utils/config_loader.py (1)
get(263-271)
| "allowed_file_types", [] | ||
| ) | ||
| final_config["use_auth"] = config_data.get("use_auth", True) | ||
| final_config["use_auth"] = config_data.get("use_auth", False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve the UX fix, but flag the security trade-off.
Changing the default to False correctly addresses the login issue where users are locked out because credentials aren't configured during onboarding. However, this means new installations start with authentication disabled, which could be a security concern if the application is exposed to untrusted networks.
Consider adding:
- Documentation or startup warnings reminding users to enable authentication
- A prominent notice in the GUI indicating authentication is disabled
- Guidance in deployment docs about when authentication should be enabled
🤖 Prompt for AI Agents
In utils/decypharr_settings.py around line 81, the default for "use_auth" was
changed to False which fixes onboarding lockouts but lowers security for default
installs; update the project to mitigate this trade-off by adding a startup-time
warning and documentation: emit a clear log/warnings.warn at application startup
when use_auth is False (including guidance to enable authentication), add a
prominent notice in the GUI/dashboard indicating authentication is disabled, and
augment deployment/onboarding docs with explicit instructions on when and how to
enable authentication and recommended network exposure settings.
Making this value true by default will cause the user to be unable to login, and no value is set for login credentials during onboarding.
The user can set their username and password afterwards in the Decypharr GUI, modifying the configuration as desired once set.
Summary by CodeRabbit