Attach artifacts to the release #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use mise and want to be able to use the hyphen CLI through mise. For now, I made a vfox plugin (at https://github.com/half-ogre/vfox-hyphen), but would rather submit a PR to the mise registry with it using aqua/ubi as they discourage using asdf/vfox for new tools. That requires binaries being available on the GitHub releases. So, this PR modifies the prod deploy to attach the binaries to the release.
I tested this by commenting out the R2 and Windows parts in my fork. You can see the run at https://github.com/half-ogre/hx/actions/runs/18137353999 and the release with the artifacts attached at https://github.com/half-ogre/hx/releases/tag/untagged-e86cb130d7b2603c18a0.
If you don't want to take this, all good; closing it won't hurt my feelings!
(If you do take this, it won't cover attaching the binaries to the existing releases, but I could push up another workflow to do just that via workflow dispatch.)