Adding ratings_CDA_test.py and Additional resources #195
Conversation
Create ratings_test.py
Added JSONs and more properly setup the file
Update ratings_CDA_test.py
Update location.json
added changes
Enovotny
left a comment
Enovotny
left a comment
There was a problem hiding this comment.
looks good so far. have some comments
update based on comments
Update location.json
Switching to XML
Update ratings_CDA_test.py
Ratings cda test
Updated compatability
Update ratings_CDA_test.py
Update ratings_CDA_test.py
Ratings cda test
There was a problem hiding this comment.
overall looks good. Nice work getting those tests to complete. Have added some of the following
- formatting changes.
- additional asserts to test the .df in addition to the .json
- add tests for 2 other functions. get_rating_templates and get_rating_specs.
tlelv
left a comment
tlelv
left a comment
There was a problem hiding this comment.
Like you said on call, the next I'll work on is the tables, as well as adding asserts for both the json and df to all tests if that works!
|
lets get all of these changes in so we can commit this pull request and be done with the templates and specs. Then create a new pull request for adding the rating tables. and testing those. |
let me get those changes in, I re-requested a bit early |
Enovotny
left a comment
Enovotny
left a comment
There was a problem hiding this comment.
we are really close. one thing to keep in mind anything that is created in the a test needs to be removed. so we need a mechanism to remove the 2nd template/specs that are created. I created a test file for levels. check out what is done there. check out test_get_specified_levels(): in
|
Enovotny
left a comment
Enovotny
left a comment
There was a problem hiding this comment.
nice work. Looks good. go ahead and merge.
No description provided.