ci/cd: build on push, release on tag - #44
Conversation
|
Looks good. Is there an easy way to check the tag string conforms to a valid version identifier? This would allow tags to be used for other purposes, including tagging alpha, beta versions without creating PyPI releases for them. |
I think we can have a validation of the tag, and terminates early if fails. I will polish this PR a bit, and ping you once ready. |
|
ping @apdavison can you take a look again? I have added a step which checks the tag matches which would allow:
(edited) |
|
hi @xgui3783 : I don't think we should publish dev, alpha, beta or rc versions to PyPI |
|
good point. updated (up point is regex is also much simper) |
This PR adds CI/CD which:
largely following guide from https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#workflow-definition
edit: TODO: after merge, someone with pypi publish right (me, andrew etc) will need to continue the guide, specifically registering trusted publishing at https://pypi.org/manage/account/publishing/