Adapt to refactoring of nimib #52
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pietroppeter It's long due but I have managed to rewrite a large part of nimiSlides to use the new nimib version. The ones we were most interested in was
slideandfragmentCoreas they are now container blocks.Everything is not ported yet, there is still a lot of
nbRawHtmlsprinkled around everywhere. And for good reason, it's so damn easy and convenient 😅. So I'm not sure if it's worth the effort to define a new block type for each one. Take for example:It would translate to this code roughly:
It is not that much code, but there are a few of them. I mean, I should port them over but I'm just lazy. Can you remind me of a good reason why I should do it and then I'll do it? 🤣