Add optional assistant.threads.setStatus params - #470
Merged
VictorHLi404 merged 2 commits intoAug 12, 2026
Conversation
Slack's assistant.threads.setStatus supports four optional arguments we weren't exposing (loading_messages, icon_emoji, icon_url, username), so callers had no way to drive the animated loading indicator or override the status message's icon/username. This adds all four to SetThreadStatusParams for full parity with the API. loading_messages carries a guard for Slack's documented maximum of 10 so we fail fast rather than letting Slack reject the request. Serialization is set up so unused optionals are omitted entirely (NON_ABSENT for the optionals, NON_EMPTY for the list) rather than sending null/[] values. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
opaliukh
reviewed
Aug 12, 2026
- Rename @Value.Check method to checkLoadingMessagesWithinLimit to match the check* prefix convention used throughout this repo - Add checkIconNotBothPresent guard since Slack treats icon_emoji and icon_url as mutually exclusive; fail fast rather than waiting for an API rejection - Add smoke test for the three Optional fields (icon_emoji, icon_url, username) and a test covering the mutually-exclusive icon guard Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
opaliukh
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Slack's
assistant.threads.setStatussupports four optional arguments thatSetThreadStatusParamsdidn't expose, so callers had no way to drive the animated loading indicator or override the status message's icon/username.What
Adds all four optional arguments for full parity with the API:
loading_messagesList<String>icon_emojiOptional<String>icon_urlOptional<String>usernameOptional<String>loading_messagescarries a guard for Slack's documented maximum of 10 so we fail fast rather than letting Slack reject the request.NON_ABSENTfor the optionals,NON_EMPTYfor the list) rather than sendingnull/[].SetThreadStatusParamsValidationTestcovering the empty, at-limit, and over-limit cases.🤖 Generated with Claude Code