Fix const_get
arguments in api models
#428
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hubspot::Discovery::BaseApiClient#require_api_models
overrides theconst_get
method for generated classes under certain circumstances, but the override only accepts one argument, whereas the originalModule#const_get
accepts two. This can be a problem when mocking these classes in tests, such as when usinginstance_double
from rspec-mocks.For example:
This fixes that by adding anonymous arguments to the method override, letting the
super
call handle the extra argument.