Implemented tree using classes, additional functionality#8
Open
revan730 wants to merge 2 commits intoHowProgrammingWorks:masterfrom
Open
Implemented tree using classes, additional functionality#8revan730 wants to merge 2 commits intoHowProgrammingWorks:masterfrom
revan730 wants to merge 2 commits intoHowProgrammingWorks:masterfrom
Conversation
tshemsedinov
requested changes
Mar 4, 2017
Member
tshemsedinov
left a comment
tshemsedinov
left a comment
There was a problem hiding this comment.
В общем код достаточно внятный и чистый
JavaScript/4-class.js
Outdated
| } | ||
|
|
||
| findAll(name) { // Find all nodes with specified name | ||
| let arr = []; |
JavaScript/4-class.js
Outdated
| find(name, callback) { //Call function for each found node | ||
| const nodes = this.findAll(name); | ||
| if (nodes.length > 0) | ||
| for (let n of this.findAll(name)) |
Member
There was a problem hiding this comment.
со скобками {} будет лучше и if и for
JavaScript/4-class.js
Outdated
| } | ||
|
|
||
| setParent(newParent) { // Sets new parent for this node | ||
| this.parent.childs.pop(this.parent.childs.indexOf(this)); |
JavaScript/4-class.js
Outdated
|
|
||
| console.log('findAll("searched") -', root.findAll('searched')); | ||
| console.log('findFirst("searched") -', root.findFirst('searched')); | ||
| root.find('n2', n => { |
Member
There was a problem hiding this comment.
Вот тут {} можно опустить
n => console.log(...
JavaScript/4-class.js
Outdated
| findAll(name) { // Find all nodes with specified name | ||
| let arr = []; | ||
| if (this.name === name) arr.push(this); | ||
| for (let n of this.childs) { |
Member
There was a problem hiding this comment.
Тут ходить по массиву обычным циклом, for..of пока медленный
JavaScript/4-class.js
Outdated
|
|
||
| findFirst(name) { //Find first instance | ||
| if (this.name === name) return this; | ||
| for (let n of this.childs) { |
Member
There was a problem hiding this comment.
тоже без for..of лучше избавиться, а переменную содавать до цикла:
let i;
for (i = 0; ...
это работает быстрее
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented tree using ES6 classes, added next methods: